Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alzollin/markdown features #588

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Alzollin/markdown features #588

merged 5 commits into from
Nov 25, 2024

Conversation

azchohfi
Copy link
Contributor

No description provided.

@azchohfi azchohfi marked this pull request as ready for review November 11, 2024 22:27
@Arlodotexe Arlodotexe linked an issue Nov 13, 2024 that may be closed by this pull request
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these changes seem pretty good. My only concern is that we're routing the event for handling clicks via the config object, which makes it more difficult to set from XAML.

@azchohfi
Copy link
Contributor Author

That is a fair point, but isn't that true for any property on the config? I did it this way since it wasn't that straightforward to add it to the markdowntextblock itself, since we have no easy reference to it.

@Arlodotexe
Copy link
Member

Arlodotexe commented Nov 13, 2024

That is a fair point, but isn't that true for any property on the config? I did it this way since it wasn't that straightforward to add it to the markdowntextblock itself, since we have no easy reference to it.

True, and anything on the config could be turned into a separate dependency property if we wanted binding support for the individual options.

The distinction seems to be that the config options (custom svg renderer, image provider) are a bit more advanced than a LinkClicked handler. These would likely need to be set up in code-behind anyway, whereas you might expect LinkClicked to show when declaring the type in XAML.

@Arlodotexe
Copy link
Member

This is also the behavior from the 7.x version of our MarkdownTextBlock.

@azchohfi
Copy link
Contributor Author

You are right. Done.

Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This will see plenty of usage and brings us closer to feature parity with the 7.x control. Let's ship it 🚀

@nerocui
Copy link
Collaborator

nerocui commented Nov 15, 2024

Nice set of changes! Are we merging this soon?

@michael-hawker
Copy link
Member

michael-hawker commented Nov 22, 2024

@azchohfi would you have a chance to rebase this PR? Then we can merge:

image

I tried locally, but there are conflicting changes with your other PR #586 (at least that's what I thought the merge view said, but then I don't see the changed file) that I'm not 100% confident in resolving in MyHyperlinkButton.cs within the constructor.

@michael-hawker
Copy link
Member

Ah I see the conflict is from #587 - that maybe helps as that is simple. I'll see if I can rebase this myself again.

@michael-hawker michael-hawker force-pushed the alzollin/markdownFeatures branch from 7e039e3 to 02d27e4 Compare November 22, 2024 19:33
@michael-hawker michael-hawker enabled auto-merge (rebase) November 22, 2024 19:34
@michael-hawker
Copy link
Member

Alright, all fixed! Set to auto-merge once the CI passes, thanks folks!

@michael-hawker michael-hawker merged commit 6dafb91 into main Nov 25, 2024
20 of 21 checks passed
@azchohfi azchohfi deleted the alzollin/markdownFeatures branch November 25, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdig-based MarkdownTextBlock doesn't support clicking hyperlinks
4 participants